accept unicode strings in parse_string() under Python 2 #49

Merged
merged 1 commit into from May 31, 2015

Projects

None yet

2 participants

@drewbrew
Contributor

In Python 3, strings are unicode, so this problem does not exist, but in Python 2, if you call parse_string(u"20 GiB"), it'll raise a ValueError.

@drewbrew drewbrew bitmath: accept unicode strings in Python 2
In Python 3, str == unicode, so this problem does not exist, but in
Python 2, if you call `parse_string(u"20 GiB")`, it'll raise a
ValueError.
05e9729
@tbielawa tbielawa self-assigned this May 29, 2015
@tbielawa
Owner

Reviewed. Looks good!

Thanks @drewbrew merged!

@tbielawa tbielawa merged commit b568258 into tbielawa:master May 31, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@drewbrew drewbrew deleted the drewbrew:support-unicode-in-parse-string branch Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment