New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept unicode strings in parse_string() under Python 2 #49

Merged
merged 1 commit into from May 31, 2015

Conversation

Projects
None yet
2 participants
@drewbrew
Copy link
Contributor

drewbrew commented May 28, 2015

In Python 3, strings are unicode, so this problem does not exist, but in Python 2, if you call parse_string(u"20 GiB"), it'll raise a ValueError.

bitmath: accept unicode strings in Python 2
In Python 3, str == unicode, so this problem does not exist, but in
Python 2, if you call `parse_string(u"20 GiB")`, it'll raise a
ValueError.

@drewbrew drewbrew force-pushed the drewbrew:support-unicode-in-parse-string branch from 9e78dbc to 05e9729 May 28, 2015

@tbielawa tbielawa self-assigned this May 29, 2015

@tbielawa

This comment has been minimized.

Copy link
Owner

tbielawa commented May 31, 2015

Reviewed. Looks good!

Thanks @drewbrew merged!

tbielawa added a commit that referenced this pull request May 31, 2015

Merge pull request #49 from drewbrew/support-unicode-in-parse-string
accept unicode strings in parse_string() under Python 2

@tbielawa tbielawa merged commit b568258 into tbielawa:master May 31, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@drewbrew drewbrew deleted the drewbrew:support-unicode-in-parse-string branch Jun 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment