Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove bin folder in Gradle projects #86

Merged
merged 1 commit into from May 22, 2023

Conversation

Lipen
Copy link
Contributor

@Lipen Lipen commented May 21, 2023

#81 introduced support for Gradle projects, however I would advise against counting the bin folder as part of the "build files". AFAIK, Gradle only uses build folder for artifacts and .gradle for Gradle wrapper.
I do believe, many people build/download "external" binaries and put them in the bin folder. Sometimes, this is a part of automatic build process, and the removal of such binaries is "revertable". However, I also believe that some people (e.g., me, at least) do this manually, since it is being done only once. For example, in the cases when these binaries are necessary only for integration tests or for some extra functionality.

Long story short, bin folder is definitely should not be considered as "build files".

@tbillington
Copy link
Owner

Thank you for the detailed explanation, that makes sense to me.

@tbillington tbillington merged commit b896e2c into tbillington:master May 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants