🧹️🧼 Cleanup: addFuncDef/clearFuncDefs should all use a non-static pool #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new interface
- Implemented new `IFuncDefStore` type
- The constructor now takes in a `TypeChecker` instance - Implemented `addFunctionDef(Function func)`
- Added a TODO + some code for a future naming setup I want to se
- Added documentation - Added new method `grabFunctionDef(string name)` to the API
- Added new exception type
- Added more docs for `grabFunctionDef(string name)`
- Pass in ourselves (a `IFuncDefStore`) into the `DFunctionInnerGenerator` when adding a function definition - Implemented `grabFunctionDef(string name)` from the updated `IFuncDefStore` API
- Constructor now takes in a `IFuncDefStore` - When we encounter a `Function` we will add it to the store of function definitions by using the new `IFuncDefStore` (instead of the old `addFunctionDef(TypeChecker, Function)` - Removed unused method `saveFunctionDefinitionNode(DNode funcDefNode)` - Removed unused method `retrieveFunctionDefinitionNode(string functionAbsolutePath)` - Removed the old method `addFunctionDef(TypeChecker tc, Function func)` (as we are now using the `IFuncDefStore`) - Removed the `clearFuncDefs()` as we are now using the `IFuncDefStore` - Removed the `grabFunctionDefs()` as we are now using the `IFuncDefStore` - Removed the `FunctionData[string]` as we are now using the `IFuncDefStore` DFunctionInnerGenerator - Constructor now takes in a `IFuncDefStore`
- `dependencyCheck()` no lomger calls the removed `clearFuncDefs()` from the `dependency.core` module - `dependencyCheck()` now constructs a new `IFuncDefStore` and then passes it into the `DNodeGenerator` when dependency generation needs to occur
- Added module-level documentation
- Documented class - Documented module
- Documented constructor and class
- `addFunctionDef(Function func)` may now throw a `FuncDefStoreException` when you add a function that already exists
- `addFunctionDef(Function func)` now throws a `FuncDefStoreException` when you provide a `Function` that has already been added
- Moved import to the top
- Cleaned up
|
Updated with latest code from |
|
Merging... |
|
Merged ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see this.