🐞️ Bugfix: Binary Operators support for non-Integer types #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disallow the operands of ANY binary operator expression to both be pointer types
- When transforming a `CastedValueInstructionA` ensure that we wrap the expression being-casted in `(<expr>)` (parenthesis) because otherwise C is unhappy and in cases, like binary operator expressions, it will cause the C compiler to attempt casting the left-hand operand not the resultant of the binary operator expression - When doing an emit for `BinaryOperatorExpression`, ignore the case whereby ether left or right-hand side operand s a pointer type and ONLY when) the operatr is `SymbolType.EQUALS`
- Do allow `SymbolType.EQUALS` with two pointer operands - Removed false assertion in exhaustive case - If thebinary operator is `SymbolType.EQUALS` then set `chosenType` to `ubyte`
- Added `simple_binops_ptr_bad.t` and `simple_binbops_ptr.t`
- Added `source/tlang/testing/typecheck/simple_binops_ptr_bad.t` - Added `source/tlang/testing/simple_binops_ptr.t`
deavmi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see this.