Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate `-Djit=true` option to `-Dengine=jit`. #529

Merged
merged 2 commits into from Oct 20, 2019

Conversation

@MatthewMerrill
Copy link
Contributor

MatthewMerrill commented Oct 20, 2019

-Djit=true => -Dengine=jit
-Djit=false => -Dengine=interp

This has the side effect of making it impossible to
compile in what was `-Djit=false`.
@tbodt
tbodt approved these changes Oct 20, 2019
Copy link
Owner

tbodt left a comment

LGTM, Approval

Auto submit NOT triggered by reviewer.

@MatthewMerrill

This comment has been minimized.

Copy link
Contributor Author

MatthewMerrill commented Oct 20, 2019

Changed description:

+R=startblock
+Startblock:
+ passes presubmit
+WANT_LGTM=all
@tbodt

This comment has been minimized.

Copy link
Owner

tbodt commented Oct 20, 2019

FYI All affected tests pass!

@tbodt tbodt merged commit 556d54e into tbodt:master Oct 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MatthewMerrill MatthewMerrill deleted the MatthewMerrill:engine_jit_options branch Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.