Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate -Djit=true option to -Dengine=jit. #529

Merged
merged 2 commits into from
Oct 20, 2019
Merged

Migrate -Djit=true option to -Dengine=jit. #529

merged 2 commits into from
Oct 20, 2019

Conversation

MatthewMerrill
Copy link
Contributor

@MatthewMerrill MatthewMerrill commented Oct 20, 2019 •
edited
Loading

-Djit=true => -Dengine=jit
-Djit=false => -Dengine=interp

@MatthewMerrill
Migrate -Djit=true option to -Dengine=jit.
e8215be 
This has the side effect of making it impossible to
compile in what was `-Djit=false`.
@MatthewMerrill
Remove redundant default, add interp option.
a8a88b7
tbodt
tbodt approved these changes Oct 20, 2019
View reviewed changes
Copy link
Member

@tbodt tbodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Approval

Auto submit NOT triggered by reviewer.

@MatthewMerrill
Copy link
Contributor Author

MatthewMerrill commented Oct 20, 2019 •
edited
Loading

Changed description:

+R=startblock
+Startblock:
+ passes presubmit
+WANT_LGTM=all

@tbodt
Copy link
Member

tbodt commented Oct 20, 2019

FYI All affected tests pass!

@tbodt tbodt merged commit 556d54e into ish-app:master Oct 20, 2019
@MatthewMerrill MatthewMerrill deleted the engine_jit_options branch October 20, 2019 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbodt tbodt tbodt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewMerrill @tbodt