Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 5.6 support #284

Merged
merged 2 commits into from
Oct 9, 2022
Merged

Fix PHP 5.6 support #284

merged 2 commits into from
Oct 9, 2022

Conversation

paxter
Copy link
Contributor

@paxter paxter commented Oct 9, 2022

Latest update breaks PHP >= 5.6 support.

fix PHP 5.6 support
src/Imdb/Title.php Outdated Show resolved Hide resolved
@jreklund jreklund merged commit 190868a into tboothman:master Oct 9, 2022
@jreklund
Copy link
Collaborator

jreklund commented Oct 9, 2022

Thanks, I haven't written PHP 5.6 code in years. Are you still using it?

@paxter
Copy link
Contributor Author

paxter commented Oct 9, 2022

Yep. PHP 5.6 is still used in many production environments.

@jreklund
Copy link
Collaborator

jreklund commented Oct 9, 2022

You really need to switch ASAP, that version had an end of life over three years ago. There are currently 0,5% using that version according to packagist. imdbphp are compatible with PHP 8.0.

@tboothman
Copy link
Owner

It does say in the readme we support 5.6 to be fair. I used to test it on travis then they dropped support for it .. then travis dropped support for free builds so only really testing 7.4 at the moment with a github action.

@paxter
Copy link
Contributor Author

paxter commented Oct 10, 2022

You really need to switch ASAP, that version had an end of life over three years ago. There are currently 0,5% using that version according to packagist. imdbphp are compatible with PHP 8.0.

As I said. It's still used in many production environments. There are also some unix/linux derivates who are still provide updates for php 5.6 packages. So please stop any religious topic spamming and don't tell me what I have to use. Thanks.

Readme states php 5.6 is still supported, then this software should be work with that version. Or just update your readme.

@jreklund
Copy link
Collaborator

jreklund commented Oct 10, 2022

tboothman: It does say in the readme we support 5.6 to be fair.

paxter: Readme states php 5.6 is still supported, then this software should be work with that version.

I'm not question the legitimacy of this PR, it's up to specification of the project.

So please stop any religious topic spamming and don't tell me what I have to use.

I'm not trying to be an asshole about it, just said it ones... you are free to use enterprise Linux if you like. Haven't come across any supported version of Linux that are still using PHP 5.6 as of late, but it appears Red Hat 7 are one, if you use their extended support channel. (stopped using Red Hat / CentOS around 2015 due to software requirements changes e.g. PHP)

PHP are moving fast and getting a lot new features that makes it more of a type safe language. If you are into that sort of things. It's quite a leap upgrading an old program if you want to utilize all the features it offerts. You can still create quick and dirty applications that can run on multiple versions.

@XaXo81
Copy link

XaXo81 commented Oct 11, 2022

Yep. PHP 5.6 is still used in many production environments.

I Agree with that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants