Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utf8 printing support #27

Merged
merged 5 commits into from
Dec 6, 2020
Merged

Utf8 printing support #27

merged 5 commits into from
Dec 6, 2020

Conversation

laelnasan
Copy link
Contributor

Adds utf8 printing and input support
it will not affect ascii implementations

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

 Changes to be committed:
	modified:   src/ltui/label.lua
	modified:   src/ltui/textedit.lua
Changes to be committed:
	modified:   src/ltui/label.lua
	modified:   src/ltui/textedit.lua
 Changes to be committed:
	modified:   src/ltui/textedit.lua
 Changes to be committed:
	modified:   src/ltui/textedit.lua
@waruqi
Copy link
Member

waruqi commented Dec 6, 2020

Oh, it's great. I will test it in these days. BTW, can you help me add a simple test example with utf8 characters in tests directory?

Thanks.

@waruqi waruqi merged commit cdfbe51 into tboox:dev Dec 6, 2020
line = line:sub(width + 1)
local size = 0
for i = 1, #line do
if (line:byte(i) & 0xc0) ~= 0x80 then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, It does not work on luajit. We need bit module. bit.band(a, b)

self:text_set(text:sub(1, #text - 1))
local size = 1
-- while continuation byte
while (text:byte(#text - size + 1) & 0xc0) == 0x80 do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants