Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Puma #136

Merged
merged 2 commits into from
Feb 27, 2018
Merged

Conversation

georgeu2000
Copy link
Contributor

No description provided.

@waghanza
Copy link
Collaborator

@georgeu2000 👍 using the default webrick instead of puma will break benchmark suite for ruby ;-)

after each launch, the puma process is killed by the benchmarking tool

  • would you mind remove the ruby version in Gemfile (break portability) ?

@tbrand If you need I can propose myself to review / merge PR 😜 (especially for ruby / crystal )

@tbrand
Copy link
Collaborator

tbrand commented Feb 25, 2018

@waghanza That's the reason why I added you into this repository as a collaborator. 👍

@waghanza
Copy link
Collaborator

@tbrand I still see the Contributor flag on my message

@georgeu2000
Copy link
Contributor Author

georgeu2000 commented Feb 25, 2018

@waghanza

using the default webrick instead of puma will break benchmark suite for ruby ;-)

It sure did.

would you mind remove the ruby version in Gemfile (break portability) ?

Done.

@tbrand
Copy link
Collaborator

tbrand commented Feb 27, 2018

@waghanza I already sent an invite email to you. ✉️

@waghanza
Copy link
Collaborator

waghanza commented Feb 27, 2018

@tbrand sure ... now I have seen. The email was drow on my messy inbox 😉

@tbrand: If you prefer, I will be confortable using Squash and merge for PR. The default merge and merge by rebase could be disabled from the web interface

@waghanza waghanza merged commit 8e2a627 into the-benchmarker:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants