Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade actix to version 0.4 #147

Merged
merged 1 commit into from Mar 1, 2018
Merged

Upgrade actix to version 0.4 #147

merged 1 commit into from Mar 1, 2018

Conversation

fafhrd91
Copy link
Contributor

No description provided.

@waghanza
Copy link
Collaborator

waghanza commented Feb 28, 2018

@fafhrd91 good catch, but could you remove version checking -> not revelant in our case
I don't know about rust but probably a * will install the latest stable
PS : ⚠️ do not manually edit README.md, it's autogenerated

@fafhrd91
Copy link
Contributor Author

fafhrd91 commented Feb 28, 2018

do you mean remove version from actix project?

this is not good idea, 0.4 is major api change. if you put "*" you may end up in situation when project stops compile suddenly

@waghanza
Copy link
Collaborator

@fafhrd91 probably, I can fix it upgrading to latest stable.

The goal of this project is only about comparison, but it could be accurate to compare last stable version, na ?

@fafhrd91
Copy link
Contributor Author

But for sure, you want result be reproducible and in this case it is just easier to pin versions

@waghanza waghanza merged commit db0a01e into the-benchmarker:master Mar 1, 2018
@fafhrd91
Copy link
Contributor Author

fafhrd91 commented Mar 3, 2018

btw when do you guys plan to run bench again?

@waghanza
Copy link
Collaborator

waghanza commented Mar 3, 2018

@fafhrd91 not an idea 😝 in fact @tbrand display the result

=> rust is not working for me

@fafhrd91
Copy link
Contributor Author

fafhrd91 commented Mar 3, 2018

I don’t understand your comment

@waghanza
Copy link
Collaborator

waghanza commented Mar 3, 2018

@fafhrd91 I mean, we split work


@tbrand display the result and I help maintaining, so I can give you any date

@tbrand will answer :-)

@fafhrd91
Copy link
Contributor Author

fafhrd91 commented Mar 3, 2018

ok, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants