Jasmine/QUnit tests no longer bootstrap main app #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not so sure about adding an additional run file just yet. Might be simple enough to require the config and override the deps property, which I'm pretty sure I've seen done already. |
|
I changed the app module to take on more application-like responsibility and changed the role of main. This allows us to not depend on so much coupling. https://github.com/tbranyen/backbone-boilerplate/blob/wip/app/main.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #195.
This commit moves the bootstrapping of the app from
config.jsto a newrun.jsscript, which is started by the mainindex.htmlfile, but not by the jasmine/qunit ones.grunt.jsalso updated to ensure debug/release builds still work OK.