-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies with missing ones (Fix #237) #238
Conversation
What dependencies are missing? Why are we using
|
@tbranyen Apparently, the
|
It's because of the brittle nature of |
Yup, I think though a fix in load-grunt-task to skip grunt-cli should be ok. I don't see much advantages to declaring BTW, I'm not sure I see where you'd need to install bower/grunt-cli locally? |
There was some missing dependencies, and some weirdness in the package.json. This should be fixed. Bower and grunt-cli have been moved back to the peerDependencies; if running on travis-CI or similar and having issues, you should install those two in the pre-build script.
@SBoudrias I posed the question to @cowboy about this and I'd like to follow his advice on how to structure the Gruntfile. For reference: cowboy/wesbos#5 |
Fixed the package.json via: c73b22e This updates the .travis.yml file to automatically install the correct dependencies exactly per the Markdown. |
Integrated your changes here: be559d0...0ea0358 |
That looks good to me |
There was some missing dependencies, and some weirdness in the
package.json. This should be fixed. Bower and grunt-cli have been moved
back to the peerDependencies; if running on travis-CI or similar and
having issues, you should install those two in the pre-build script.
I send a PR because I'm unsure why/how the package.json file have reach the previous state.