New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #383. Refactored test suite to use bower_components so we catch thes... #384
Conversation
…hese errors by staying on top of dep updates. QUnit update now throws errors upon improper use of asyncTest/start/stop, so I fixed those errors as well. Removed test/vendor and test/qunit directory as they are no longer needed. Added test/spec directory.
@@ -1,2 +1,4 @@ | |||
node_modules | |||
test/report | |||
bower_components | |||
.DS_Store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW global files ignore can/should be added to your own global .gitignore. That helps only keeping project related ignores in the local .gitignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, will remove & update.
Looks like bower needs to be added to devDependencies. |
|
Its only for our needs, devDependencies should work fine. Travis puts everything in your PATH anyways. |
Yeah, that seems right, bower & grunt both won't run at all even if installed in node_modules, so they should be For example, yeoman's package.json |
What was the reason for moving tests into test/specs? |
I thought it was clearer. It isn't immediately obvious that |
Not a big deal, just calling it out because it's not relevant to the fix in issue 383. I'd like @jugglinmike to comment on this before merging. |
I agree that it's better to have the tests themselves in a dedicated directory. It would be nice to see the resolution of #383 in an independent commit, although it sounds like I'm alone on that. |
Okay cool, merging. |
Fix #383. Refactored test suite to use bower_components so we catch thes...
Thanks @ssafejava! |
...e errors by staying on top of dep updates. Added a test in views.js to catch this particular error explicitly.
QUnit update now throws errors upon improper use of asyncTest/start/stop, so I fixed those errors as well.
Removed test/vendor and test/qunit directory as they are no longer needed.
Added test/spec directory.