Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This occurred to me when reviewing #404. It would be easy to simply update the test to ensure that some Error was thrown, but I think we can do better. Not only does this change make writing this test easier, it also makes using LayoutManager easier:
Currently, if a developer has some special logic to recover from (or log) LayoutManager issues, there's no obvious way to do this:
With a custom Error class, this is simple:
I'll admit that it does seem a little unlikely that people will need this for LayoutManager's one and only Error. This also isn't a pattern I've seen in other JavaScript libraries. That said, having it around (and documented) means that we can easily reach for it in the future (where Errors thrown from more dynamic code paths would make it more important).