Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal Grammar has some flaws #66

Closed
tbranyen opened this issue May 3, 2015 · 1 comment
Closed

Internal Grammar has some flaws #66

tbranyen opened this issue May 3, 2015 · 1 comment

Comments

@tbranyen
Copy link
Owner

tbranyen commented May 3, 2015

There are some flaws with in the internal grammar, such that it is required to have START_IF represented as if_ instead of if. This is also true for:

  • ELSIF
  • NOT
  • AS

Corrections to the stack/tree builder are required to alleviate this. It is problematic, because currently the following template:

{%if%}...{%endif%}

Gets the incorrect error: Error: Invalid expression type: OTHER. The expected error is: Error: Missing conditions to if statement.
tbranyen added a commit that referenced this issue May 3, 2015
@tbranyen
Fixes issues with grammar
f9b0ca3 
As reported in #66 there was a
flaw with our grammar parsing for high level tokens.

This fixes the issue by removing whitespace from areas where it is
insignificant.
@tbranyen
Copy link
Owner Author

tbranyen commented May 3, 2015

Closed via f9b0ca3

@tbranyen tbranyen closed this as completed May 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbranyen