Add missing package.json fields and upgrade dev dependencies #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NPM Install complained about no license or repository fields, so I added those in. Many dev dependencies were producing errors about unsatisfied peer dependencies in the upcoming NPM 3 world, so those were also added (phantomjs and karma, notably).
| "amdefine": "^1.0.0", | ||
| "browserify": "^11.0.1", | ||
| "dateformat": "^1.0.11", |
There was a problem hiding this comment.
The "dateformat" change was just "npm install --save-dev" re-ordering the list
|
Made you a collab, feel free to merge once this passes. |
|
@tbranyen The sauce labs check is failing, and I'm not familiar with that part. Any ideas what might be going wrong? Also, thanks! |
|
Yeah, that's fine. For whatever reason SauceLabs won't run unless I'm the committer. |
kadamwhite
added a commit
that referenced
this pull request
Aug 25, 2015
…-dev-dependencies Add missing package.json fields and upgrade dev dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM Install complained about no license or repository fields, so I added those in.
Many dev dependencies were producing errors about unsatisfied peer dependencies in the upcoming NPM 3 world, so those were also added (phantomjs, mocha and karma, notably).