Implements createSideEffect #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests and improvements to createState and createSideEffect. Specifically around error handling and awaiting a state change.
tbranyen
force-pushed
the
create-side-effect
branch
from
8ad6692
to
f2b4b4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
createSideEffectwhich matchesuseEffectfrom React. It is currently incomplete, but in a somewhat usable form. I need to do some refactoring around how/when we call lifecycle methods as the current approach isn't entirely accurate.Right now we call
componentWillUnmountafter patching, which is not right, it should happen before the element actually unmounts.