Support for key attribute to aid reconcilation
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tbranyen
force-pushed
the
better-remove
branch
2 times, most recently
from
a03d343
to
51bfa30
Compare
|
Smarter algo added! |
tbranyen
force-pushed
the
better-remove
branch
3 times, most recently
from
f3039f7
to
c2900be
Compare
This is a proof-of-concept implementation that needs more testing. It works well for a super basic use case, but I need to do more testing to ensure it works as expected. I've also migrated the `is` attribute directly to the VDOM descriptor. This eliminated two `Array#some` loops. I resisted the urge to change to more `const`s.
Fixed a bug where slice was used instead of concat for producing an array of elements. I explicitly filter elements to detached/attached to be real elements (no text nodes). This includes a smarter remove for key attributes. In the future it'd be nice to do a replace by key as well for sorting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in a smart algorithm to detect changes between element keys.