Work to support a Babel transform #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbranyen
force-pushed
the
transform
branch
4 times, most recently
from
8194e68
to
d02cf5f
Compare
| @@ -39,10 +39,10 @@ export default function make(descriptor) { | |||
|
|
|||
| // If not a dynamic type, set as an attribute, since it's a valid | |||
| // attribute value. | |||
| if (!isObject && !isFunction) { | |||
| if (attr.name && !isObject && !isFunction) { | |||
There was a problem hiding this comment.
Empty attribute names indicate a removal of a dynamic attribute.
tbranyen
changed the title
tbranyen
force-pushed
the
transform
branch
2 times, most recently
from
9892d16
to
dbc6f64
Compare
|
Once the memory leak is resolved, this should be merge-able. |
There were unit tests that leaked memory (ended up finding the source in lib/node/make) and I couldn't tell which. I added validateMemory to the unit tests that matter to narrow down where leakage occurs.
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional work needed to happen to diffHTML to support the Babel transform.