New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically change branch name if it already exists #108
Comments
Thank you for pointing this out, Daniel! Sorry for the annoyance. I do think it'd be a good idea for the tool to detect if the |
No worries at all. Would you accept a PR giving a warning about this? e.g. I wrote about this tool here for using it for some Julia packages, and I gave this warning:
Maybe a more concise version of this warning somewhere in this repo could be appropriate. |
Sure, I would accept such a PR! Thank you for the suggestion. |
Also, thank you for writing about this tool! That's cool to see. |
I had made a PR to someones repo with this tool, and then had to follow up with another PR to include some other file types. Unfortunately, after going through all the corrections it then told me that the branch already exists:
so I then had to go and do the entire thing again (and again after I didn't realise I should've deleted the branch in the github-spellcheck repo rather than my fork of Manopt.jl, but that's on me).
Would it be a good idea to make the branch name change by default if
fix-typos
already exists (or, if not, check for the existence of this branch first before any work is done) and, if it does, use e.g.fix-typos-2
? (and iffix-typos-n
exists, suefix-typos-n+1
.) I'd make a PR to address this myself but I don't know any JavaScript to read any of the code.The text was updated successfully, but these errors were encountered: