Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with newlines for quotes in text format #6

Closed
zagl opened this issue Apr 30, 2022 · 4 comments
Closed

Problems with newlines for quotes in text format #6

zagl opened this issue Apr 30, 2022 · 4 comments

Comments

@zagl
Copy link

zagl commented Apr 30, 2022

If there are newlines in the quoted message there is only one greater-than sign before the first line. I think it would be more consistent if every line of the quoted text had a leading greater-than sign.

Current output

From: xxxx
Sent: Wed, 26 Jan 2022 22:13:16 +0100
Received: Wed, 26 Jan 2022 22:13:18 +0100
Message id: xxx
Thread: xxx 

> From: xxx
> Sent: Wed, 26 Jan 2022 21:24:43 +0100
>
> Some example text.
This is still part of the quote.

This is the message

Improved

From: xxxx
Sent: Wed, 26 Jan 2022 22:13:16 +0100
Received: Wed, 26 Jan 2022 22:13:18 +0100
Message id: xxx
Thread: xxx 

> From: xxx
> Sent: Wed, 26 Jan 2022 21:24:43 +0100
>
> Some example text.
> This is still part of the quote. (now with leading greater-than sign)

This is the message
@zagl
Copy link
Author

zagl commented May 1, 2022

So instead of printing a single greater-sign followed by the complete text, after every newline in the quoted text there should be another greater-sign + space.

sigbak/cmd-messages.c

Lines 488 to 489 in 38cbb01

if (qte->text != NULL)
fprintf(fp, ">\n> %s\n", qte->text);

@tbvdm tbvdm closed this as completed in 0474a36 May 1, 2022
@zagl
Copy link
Author

zagl commented May 1, 2022

Perfect. Thank you!

@tbvdm
Copy link
Owner

tbvdm commented May 1, 2022 via email

@tbvdm
Copy link
Owner

tbvdm commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants