Skip to content

Commit

Permalink
Address mficarra review
Browse files Browse the repository at this point in the history
- Make waitable in ValidateIntegerTypedArray non-optional
- Fix ValidateTypedArray reference in %TA%.p.toLocaleString
  • Loading branch information
syg committed Aug 29, 2023
1 parent b4c8ea3 commit 3428585
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions spec.html
Original file line number Diff line number Diff line change
Expand Up @@ -41159,7 +41159,7 @@ <h1>%TypedArray%.prototype.subarray ( _begin_, _end_ )</h1>
<emu-clause id="sec-%typedarray%.prototype.tolocalestring">
<h1>%TypedArray%.prototype.toLocaleString ( [ _reserved1_ [ , _reserved2_ ] ] )</h1>
<p>This is a distinct method that implements the same algorithm as `Array.prototype.toLocaleString` as defined in <emu-xref href="#sec-array.prototype.tolocalestring"></emu-xref> except that IntegerIndexedObjectLength is called in place of performing a [[Get]] of *"length"*. The implementation of the algorithm may be optimized with the knowledge that the *this* value has a fixed length when the underlying buffer is not resizable and whose <emu-xref href="#integer-index">integer-indexed</emu-xref> properties are not sparse. However, such optimization must not introduce any observable changes in the specified behaviour of the algorithm.</p>
<p>This method is not generic. ValidateTypedArray is applied to the *this* value prior to evaluating the algorithm. If its result is an abrupt completion that exception is thrown instead of evaluating the algorithm.</p>
<p>This method is not generic. ValidateTypedArray is called with the *this* value and ~SeqCst~ as arguments prior to evaluating the algorithm. If its result is an abrupt completion that exception is thrown instead of evaluating the algorithm.</p>
<emu-note>
<p>If the ECMAScript implementation includes the ECMA-402 Internationalization API this method is based upon the algorithm for `Array.prototype.toLocaleString` that is in the ECMA-402 specification.</p>
</emu-note>
Expand Down Expand Up @@ -44171,13 +44171,12 @@ <h1>Abstract Operations for Atomics</h1>
<h1>
ValidateIntegerTypedArray (
_typedArray_: an ECMAScript language value,
optional _waitable_: a Boolean,
_waitable_: a Boolean,
): either a normal completion containing an Integer-Indexed Object With Buffer Witness Record, or a throw completion
</h1>
<dl class="header">
</dl>
<emu-alg>
1. If _waitable_ is not present, set _waitable_ to *false*.
1. Let _iieoRecord_ be ? ValidateTypedArray(_typedArray_, ~Unordered~).
1. NOTE: Bounds checking is not a synchronizing operation when _typedArray_'s backing buffer is a growable SharedArrayBuffer.
1. If _waitable_ is *true*, then
Expand Down

0 comments on commit 3428585

Please sign in to comment.