Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing [N] in RegExp grammar? #1081

Open
anba opened this issue Jan 26, 2018 · 5 comments
Open

Missing [N] in RegExp grammar? #1081

anba opened this issue Jan 26, 2018 · 5 comments

Comments

@anba
Copy link
Contributor

anba commented Jan 26, 2018

Multiple RegExp grammar productions seem to be missing the new [N] grammar parameter. E.g. in 21.2.1, Pattern, Disjunction, Alternative, Term, and Assertion all need [N].
@jmdyck
Copy link
Collaborator

jmdyck commented Jan 26, 2018

See a84a54b

@mathiasbynens
Copy link
Member

Are you planning on submitting PRs for these findings? If not, I’m happy to submit a PR fixing all these once #1029 goes in.

@jmdyck
Copy link
Collaborator

jmdyck commented Jan 26, 2018

I've already got PR #1053 waiting.

@anba
Copy link
Contributor Author

anba commented Apr 13, 2018

This seems almost fixed, except that in B.1.4 Regular Expressions Patterns ClassAtomNoDash takes [N], but it is never called with [N].

@jmdyck
Copy link
Collaborator

jmdyck commented Aug 5, 2019

Right. B.1.4 appears to assume that the N parameter is added to and passed down by:

  • CharacterClass
  • ClassRanges
  • NonemptyClassRanges
  • NonemptyClassRangesNoDash
  • ClassAtom

jmdyck added a commit to jmdyck/ecma262 that referenced this issue Aug 27, 2019
@jmdyck
Editorial: Add [N] parameter to 5 productions
5820fba 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Sep 17, 2019
@jmdyck
Editorial: Add [N] parameter to 5 productions
c7198ea 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Dec 13, 2019
@jmdyck
Editorial: Add [N] parameter to 5 productions
b4ad39d 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Jan 7, 2020
@jmdyck
Editorial: Add [N] parameter to 5 productions
7be3bfd 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Jan 25, 2020
@jmdyck
Editorial: Add [N] parameter to 5 productions
7cbf498 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Feb 5, 2020
@jmdyck
Editorial: Add [N] parameter to 5 productions
fbdf1a0 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Feb 5, 2020
@jmdyck
Editorial: Add [N] parameter to 5 productions
7158983 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
@bakkot bakkot mentioned this issue Jun 9, 2020
Open
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Jun 15, 2021
@jmdyck
Editorial: Add [N] parameter to 5 productions
866c131 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Jun 23, 2021
@jmdyck
Editorial: Add [N] parameter to 5 productions
bb01351 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Jul 11, 2021
@jmdyck
Editorial: Add [N] parameter to 5 productions
e8ca5b3 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Jul 18, 2021
@jmdyck
Editorial: Add [N] parameter to 5 productions
bb4f7aa 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Jul 24, 2021
@jmdyck
Editorial: Add [N] parameter to 5 productions
cdbf14f 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Aug 17, 2021
@jmdyck
Editorial: Add [N] parameter to 5 productions
3d4c11f 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Sep 14, 2021
@jmdyck
Editorial: Add [N] parameter to 5 productions
5d412eb 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Sep 24, 2021
@jmdyck
Editorial: Add [N] parameter to 5 productions
f7c1c2c 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Sep 29, 2021
@jmdyck
Editorial: Add [N] parameter to 5 productions
42ca8e3 
Specifically, add [N] parameter to
    CharacterClass
    ClassRanges
    NonemptyClassRanges
    NonemptyClassRangesNoDash
    ClassAtom

These were implied when commit 95ec0c6 (of PR tc39#1027)...

- added [?N] to RHS occurrences of CharacterClass
  without explicitly adding [N] to the LHS occurrence CharacterClass; and

- added [N] to the LHS occurrence of ClassAtomNoDash (in Annex B)
  without adding [?N] to any RHS occurrence.

This commit propagates [N] across that gap.

(See issue tc39#1081.)
@jmdyck jmdyck mentioned this issue Mar 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mathiasbynens @anba @jmdyck