Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMissing [N] in RegExp grammar? #1081
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
See a84a54b |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
mathiasbynens
Jan 26, 2018
Member
Are you planning on submitting PRs for these findings? If not, I’m happy to submit a PR fixing all these once #1029 goes in.
|
Are you planning on submitting PRs for these findings? If not, I’m happy to submit a PR fixing all these once #1029 goes in. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
I've already got PR #1053 waiting. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
anba
Apr 13, 2018
Contributor
This seems almost fixed, except that in B.1.4 Regular Expressions Patterns ClassAtomNoDash takes [N], but it is never called with [N].
|
This seems almost fixed, except that in B.1.4 Regular Expressions Patterns ClassAtomNoDash takes [N], but it is never called with [N]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
anba commentedJan 26, 2018
Multiple RegExp grammar productions seem to be missing the new
[N]grammar parameter. E.g. in 21.2.1, Pattern, Disjunction, Alternative, Term, and Assertion all need[N].