Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup constructor.resolve only once in PerformPromise{All, Race} #1506

Open
wants to merge 2 commits into
base: master
from

Conversation

@gsathya
Copy link
Member

gsathya commented Apr 11, 2019

Fixes #1505

@leobalter
Copy link
Member

leobalter left a comment

The proposed spec text seems correct.

Show resolved Hide resolved spec.html
@bakkot

This comment has been minimized.

Copy link
Contributor

bakkot commented Apr 11, 2019

Early throwing also matches Map etc, which check before iteration. (They do Get + IsCallable rather than GetMethod.)

@gsathya

This comment has been minimized.

Copy link
Member Author

gsathya commented Apr 11, 2019

Early throwing also matches Map etc, which check before iteration. (They do Get + IsCallable rather than GetMethod.)

SGTM, I hear folks like consistency. PR updated.

@ljharb

ljharb approved these changes Apr 11, 2019

@ljharb ljharb self-assigned this Apr 11, 2019

leobalter added a commit to leobalter/test262 that referenced this pull request Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.