Editorial: Make asserts in Else clauses explicit #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
May 29, 2019
zenparsing
approved these changes
May 29, 2019
ljharb
reviewed
May 29, 2019
jmdyck
approved these changes
May 30, 2019
ljharb
pushed a commit
to shvaikalesh/ecma262
that referenced
this pull request
Jun 2, 2019
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Sep 28, 2019
ljharb
pushed a commit
to jmdyck/ecma262
that referenced
this pull request
Sep 28, 2019
- Let -> Set - Eliminate otherwise-assertions (per tc39#1559) - Change '?' to '!', because ::subtract can't return an abrupt completion. - Fix bug: '_v_' should be '_value_' - Fix bug: `_arrayTypeName_` not defined ... in Atomics.{store,wait,notify}. (In Atomics.store, it does get defined in step 5, but needs to be defined before the reference in step 3.) (In Atomics.wait, the undefined reference is in step 11, but by defining it earlier, it can also be used in the current step 3.) (In Atomics.notify, the undefined reference is in step 7.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1419.