Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Meta: add script to land PRs #1799

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@ljharb
Copy link
Member

ljharb commented Dec 2, 2019

This is a beginning attempt.

In the future I'll add more checks; this should ensure that all commit messages either have a valid prefix, or (if not the first commit), squash: or fixup: .

@ljharb ljharb added the meta label Dec 2, 2019
@ljharb ljharb force-pushed the ljharb:commit-check branch 10 times, most recently from 2605f5a to b1b0ee7 Dec 2, 2019
@ljharb

This comment has been minimized.

Copy link
Member Author

ljharb commented Dec 2, 2019

@ljharb ljharb marked this pull request as ready for review Dec 2, 2019
@ljharb ljharb force-pushed the ljharb:commit-check branch from b1b0ee7 to 032ed20 Dec 2, 2019
@bakkot

This comment has been minimized.

Copy link
Contributor

bakkot commented Dec 3, 2019

I would strongly prefer we not do this.

Edit: on PRs, that is; I'm fine with enforcing this for master.

@ljharb

This comment has been minimized.

Copy link
Member Author

ljharb commented Dec 3, 2019

I'm confused as to why, but we can discuss it during the next editor call.

@bakkot bakkot added the editor call label Dec 3, 2019
@syg syg removed the editor call label Dec 11, 2019
@ljharb

This comment has been minimized.

Copy link
Member Author

ljharb commented Dec 11, 2019

As discussed; I'll repurpose this PR to contain a "land a PR" script, which will run these validations instead of doing it on each PR.

(My understanding of the objection, which I realize I agree with, is that PR status checks should only fail when the PR author can take action to correct them)

@ljharb ljharb self-assigned this Dec 11, 2019
@ljharb ljharb changed the title bad prefix: Meta: add action to check commit messages WIP: Meta: add script to land PRs Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.