WIP: Meta: add script to land PRs #1799
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
force-pushed
the
commit-check
branch
10 times, most recently
from
2605f5a
to
b1b0ee7
Compare
|
Failing: https://github.com/tc39/ecma262/pull/1799/checks?check_run_id=330098116 |
|
I would strongly prefer we not do this. Edit: on PRs, that is; I'm fine with enforcing this for master. |
|
I'm confused as to why, but we can discuss it during the next editor call. |
|
As discussed; I'll repurpose this PR to contain a "land a PR" script, which will run these validations instead of doing it on each PR. (My understanding of the objection, which I realize I agree with, is that PR status checks should only fail when the PR author can take action to correct them) |
ljharb
changed the title
michaelficarra
added
editor call
|
TODO: Document git procedure for merging here |
ljharb
force-pushed
the
master
branch
2 times, most recently
from
1320e04
to
3d0c24c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a beginning attempt.
In the future I'll add more checks; this should ensure that all commit messages either have a valid prefix, or (if not the first commit),
squash:orfixup:.