Normative: Remove steps 2 and 4 from ProxyCreate #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
needs consensus
ljharb
requested review from
tvcutsem,
syg,
michaelficarra,
ljharb,
bakkot,
erights and
a team
ljharb
approved these changes
Dec 15, 2019
caridy
approved these changes
Dec 18, 2019
ljharb
added
has consensus
rwaldron
added
has test262 tests
and removed
needs test262 tests
graalvmbot
pushed a commit
to oracle/graaljs
that referenced
this pull request
Apr 2, 2020
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Apr 15, 2020
Implements the changes from <tc39/ecma262#1814>. Depends on D70814 Differential Revision: https://phabricator.services.mozilla.com/D70815
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 15, 2020
Implements the changes from <tc39/ecma262#1814>. Depends on D70814 Differential Revision: https://phabricator.services.mozilla.com/D70815 --HG-- extra : moz-landing-system : lando
syg
approved these changes
Apr 23, 2020
bertogg
pushed a commit
to Igalia/webkit
that referenced
this pull request
Apr 24, 2020
https://bugs.webkit.org/show_bug.cgi?id=210862 Reviewed by Ross Kirsling. JSTests: Removes expectations for 2 invalid ChakraCore tests. * ChakraCore.yaml: Mark 2 test cases as passing. * ChakraCore/test/es6/arraywithproxy.baseline: Removed. * ChakraCore/test/es6/proxytest9.baseline: Removed. * stress/proxy-revoke.js: Adjust test. * test262/expectations.yaml: Mark 12 test cases as passing. Source/JavaScriptCore: This change removes revoked Proxy checks from ProxyCreate [1], implementing tc39/ecma262#1814 and aligning JSC with SpiderMonkey. Also cleans up ProxyObject creation by using isFunction() instead of isCallable(), which are identical. [1]: https://tc39.es/ecma262/#sec-proxycreate (steps 2, 4) * runtime/ProxyObject.cpp: (JSC::ProxyObject::structureForTarget): (JSC::ProxyObject::finishCreation): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@260621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
bakkot
approved these changes
Apr 29, 2020
ljharb
force-pushed
the
remove-sensitivity-to-revocation-from-proxy-create
branch
from
7c80f1d
to
ebe4001
Compare
galpeter
added a commit
to galpeter/jerryscript
that referenced
this pull request
Oct 1, 2020
In the newer ecma262 standard (post ES11) the ProxyCreate was changed and the revoked Proxy handler/target is not checked. Related standard PR: tc39/ecma262#1814 JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.usz@partner.samsung.com
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
https://bugs.webkit.org/show_bug.cgi?id=210862 Reviewed by Ross Kirsling. JSTests: Removes expectations for 2 invalid ChakraCore tests. * ChakraCore.yaml: Mark 2 test cases as passing. * ChakraCore/test/es6/arraywithproxy.baseline: Removed. * ChakraCore/test/es6/proxytest9.baseline: Removed. * stress/proxy-revoke.js: Adjust test. * test262/expectations.yaml: Mark 12 test cases as passing. Source/JavaScriptCore: This change removes revoked Proxy checks from ProxyCreate [1], implementing tc39/ecma262#1814 and aligning JSC with SpiderMonkey. Also cleans up ProxyObject creation by using isFunction() instead of isCallable(), which are identical. [1]: https://tc39.es/ecma262/#sec-proxycreate (steps 2, 4) * runtime/ProxyObject.cpp: (JSC::ProxyObject::structureForTarget): (JSC::ProxyObject::finishCreation): Canonical link: https://commits.webkit.org/223843@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ProxyCreate is sensitive to whether its arguments are revoked proxies. If either is, it throws a TypeError. This PR alters the algorithm to remove that sensitivity. Its consequence is that a Proxy could be created successfully where target or handlers are revoked Proxy exotic objects. (It was already possible for such Proxies to exist — just not for them to be created while already in that state.)
The motivation for this change is discussed in issue #1798. Quoting @erights:
Per @caridy the intention for this PR is to
Note that while part of the motivation for this change is to reduce the observability of an object’s status as a (revoked) Proxy exotic object, it would not in itself eliminate it. It will remain possible to detect if any object is a revoked Proxy because of step 3.a. of IsArray and, for a subset of objects, through more complex maneuvers, GetFunctionRealm. It’s possible that both of these algorithms could be altered to cease revealing this information web-safely, but I’m hardly certain of that.
Fixes #1798.