Meta: Update "To make a pull request" wording #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jan 4, 2020
ljharb
approved these changes
Jan 4, 2020
This change updates the wording of the first part of the “To make a pull request” guidance in the CONTRIBUTING.md file to read: > To make a pull request (PR), fork the ecma262 repository, apply > changes to the `spec.html` file, and upload it ... Without this change, the text lacks the word “repository" after “ecma262” and the word “file” after “spec.html”.
ljharb
force-pushed
the
contributing-to-make-a-pull-request-wording
branch
from
2bb1e48
to
0a53d56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the wording of the first part of the “To make a pull request” guidance in the CONTRIBUTING.md file to read:
Without this change, the text lacks the word “repository" after “ecma262” and the word “file” after “spec.html”.