Editorial: Use Abstract Closure to set the code eval state #2681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GeneratorStart, AsyncGeneratorStart, and AsyncBlockStart, there is the following construct:
This is a fairly novel construct, but we can reduce the novelty. Specifically, consider the
<inner-steps>
: they are to be performed later, but can refer to aliases defined in the outer algorithm. These are things that we see in Abstract Closures, so we can pull out those aspects of the construct:(This has the side benefit of making the captures explicit.)
In this PR, the first commit makes the above change, and the second commit reduces the number of captured aliases by 'reconstructing' some of them within the closure.
I wasn't sure what to do about the
[fence-effects="user-code"]
annotation, but I'm guessing that ecmarkup's handling of Abstract Closures takes care of it. (Another side benefit.)(There are also "Set the code eval state" steps in Await, GeneratorYield, and AsyncGeneratorYield, but I'm assuming that #2429 or #2665 will eliminate them.)