Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Always check regular expression flags by "flags" #2791

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Normative: Always check regular expression flags by "flags" #2791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions spec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36555,12 +36555,11 @@ <h1>RegExp.prototype [ @@match ] ( _string_ )</h1>
1. Let _rx_ be the *this* value.
1. If Type(_rx_) is not Object, throw a *TypeError* exception.
1. Let _S_ be ? ToString(_string_).
1. Let _global_ be ToBoolean(? Get(_rx_, *"global"*)).
1. If _global_ is *false*, then
1. Let _flags_ be ? ToString(? Get(_rx_, *"flags"*)).
1. If _flags_ does not contain *"g"*, then
1. Return ? RegExpExec(_rx_, _S_).
1. Else,
1. Assert: _global_ is *true*.
1. Let _fullUnicode_ be ToBoolean(? Get(_rx_, *"unicode"*)).
1. If _flags_ contains *"u"*, let _fullUnicode_ be *true*. Otherwise, let _fullUnicode_ be *false*.
1. Perform ? Set(_rx_, *"lastIndex"*, *+0*<sub>𝔽</sub>, *true*).
1. Let _A_ be ! ArrayCreate(0).
1. Let _n_ be 0.
Expand Down Expand Up @@ -36626,9 +36625,10 @@ <h1>RegExp.prototype [ @@replace ] ( _string_, _replaceValue_ )</h1>
1. Let _functionalReplace_ be IsCallable(_replaceValue_).
1. If _functionalReplace_ is *false*, then
1. Set _replaceValue_ to ? ToString(_replaceValue_).
1. Let _global_ be ToBoolean(? Get(_rx_, *"global"*)).
1. Let _flags_ be ? ToString(? Get(_rx_, *"flags"*)).
1. If _flags_ contains *"g"*, let _global_ be *true*. Otherwise, let _global_ be *false*.
1. If _global_ is *true*, then
1. Let _fullUnicode_ be ToBoolean(? Get(_rx_, *"unicode"*)).
1. If _flags_ contains *"u"*, let _fullUnicode_ be *true*. Otherwise, let _fullUnicode_ be *false*.
1. Perform ? Set(_rx_, *"lastIndex"*, *+0*<sub>𝔽</sub>, *true*).
1. Let _results_ be a new empty List.
1. Let _done_ be *false*.
Expand Down