Editorial: Fix ambiguities and type mismatches in Function.prototype.toString #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec.html
Outdated
Comment on lines
30126
to
30129
| `function` NativeFunctionName `(` FormalParameters[~Yield, ~Await] `)` `{` `[` `native` `code` `]` `}` | ||
|
|
||
| NativeFunctionName : | ||
| [empty] |
There was a problem hiding this comment.
Suggested change
| `function` NativeFunctionName `(` FormalParameters[~Yield, ~Await] `)` `{` `[` `native` `code` `]` `}` | |
| NativeFunctionName : | |
| [empty] | |
| `function` NativeFunctionName? `(` FormalParameters[~Yield, ~Await] `)` `{` `[` `native` `code` `]` `}` | |
| NativeFunctionName : |
There was a problem hiding this comment.
I don't believe that would be compatible with "the portion of sourceText corresponding to |NativeFunctionName| must be StringToCodePoints(func.[[InitialName]])" (because "the portion of sourceText corresponding to |NativeFunctionName|" is an incoherent concept when |NativeFunctionName| is absent). This is one of the problems with the current text that I am attempting to fix.
gibson042
force-pushed
the
2022-07-fix-function-prototype-tostring
branch
from
9a5d05e
to
35edcf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the editorial fixes of #2695 and will serve as a rebase target for it.