Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add using and await using Declarations, SuppressedError, DisposableStack, and AsyncDisposableStack #3000

Draft
wants to merge 57 commits into
base: main
Choose a base branch
from
Draft

Add using and await using Declarations, SuppressedError, DisposableStack, and AsyncDisposableStack #3000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
9b03205
Spec text for proposal-explicit-resource-management
rbuckton Jan 23, 2023
ecbb423
Fix lint errors
rbuckton Jan 23, 2023
ab4c487
Run formatter
rbuckton Jan 23, 2023
4fce288
Fix signature for DisposeResources
rbuckton Jan 23, 2023
2fa4817
Fixes for some esmeta warnings
rbuckton Jan 23, 2023
d6fa449
Fixes for some esmeta warnings
rbuckton Jan 23, 2023
3de7dfb
Add missing ReturnIfAbrupt in DisposableStack.prototype.use
rbuckton Jan 23, 2023
290b082
More ecmarkup signature fixes
rbuckton Jan 23, 2023
75a5fa5
Change DisposeResources signature to return completion record
rbuckton Jan 24, 2023
81da84d
Order sections by property name
jmdyck Jan 24, 2023
262c6aa
Syntax of types
jmdyck Jan 24, 2023
44f8c22
id of AO clause doesn't need to include param names
jmdyck Jan 24, 2023
c24dfd0
Avoid the use of `Type()`
jmdyck Jan 24, 2023
04b95ea
Use preamble conventions from PR #2592
jmdyck Jan 24, 2023
b77a7c2
Interface names are put in `<i>` rather than `<em>`
jmdyck Jan 24, 2023
ebc69d3
A 'Slots' table should have a 'Type' column
jmdyck Jan 24, 2023
5af1a9c
Add 'UsingDeclaration' to Annex A
jmdyck Jan 24, 2023
28766d6
misc minor fixes
jmdyck Jan 24, 2023
ccc4194
add description suggestion from @jmdyck
rbuckton Jan 25, 2023
4883a6d
Add DisposeCapabilityRecord from tc39/proposal-explicit-resource-mana…
rbuckton Jan 25, 2023
f170792
Wrap UpdateEmpty calls in calls to Completion
rbuckton Jan 25, 2023
e2b2688
Run formatter
rbuckton Jan 25, 2023
dcc071f
Run formatter again
rbuckton Jan 25, 2023
66a6fd9
Fix formatting and capitalization
rbuckton Jan 26, 2023
b0ce449
Clean up DisposeResources signature, replace UpdateEmpty with assertions
rbuckton Jan 26, 2023
23bb9d1
Add 'either' in front of 'null or undefined'
rbuckton Jan 29, 2023
f4859ba
Use CreateBuiltinFunction
rbuckton Jan 29, 2023
39577fd
Address additional editor feedback (from async PR)
rbuckton Jan 30, 2023
6391354
Move BindingPattern restriction for 'using' to an early error
rbuckton Jan 30, 2023
dfd086c
Fix typo in using declaration early errors
rbuckton Jan 30, 2023
62f1dc5
Fix typos
rbuckton Jan 30, 2023
78abb8b
run formatter
rbuckton Jan 30, 2023
583df1a
Remove InstallErrorCause from SuppressedError, per 2023-jan consensus
rbuckton Jan 31, 2023
4fed117
Spec text for proposal-async-explicit-resource-management
rbuckton Jan 27, 2023
0de8de8
Run formatter
rbuckton Jan 27, 2023
de2bc56
Add 'either' in front of 'null or undefined'
rbuckton Jan 29, 2023
08cd6b4
Address editor feedback
rbuckton Jan 29, 2023
6be4e94
Address additional editor feedback
rbuckton Jan 30, 2023
77ff8db
Switch back to a production parameter, update ASI note
rbuckton Mar 22, 2023
0e5e51a
Remove 'await' restriction per March 2023 consensus. See tc39/proposa…
rbuckton Mar 27, 2023
ca51702
Adopt consensus changes from tc39/proposal-explicit-resource-manageme…
rbuckton Mar 20, 2024
cd30168
Adopt consensus changes from tc39/proposal-explicit-resource-manageme…
rbuckton Mar 21, 2024
e31c80e
Adopt typo fix from tc39/proposal-explicit-resource-management#217
rbuckton Mar 21, 2024
2a990d9
Fix typos and add temporary PR note
rbuckton Mar 22, 2024
6e90e41
Remove temporary PR note
rbuckton Mar 22, 2024
59eaa3b
Remaining consensus updates from proposal repo
rbuckton Mar 22, 2024
e0d18bd
Add missing undefined check in GetDisposeMethod
rbuckton Mar 22, 2024
633fa2c
Fix DisposeCapability leak
rbuckton Mar 25, 2024
6cf5b01
fix formatting
rbuckton Mar 25, 2024
3cc21aa
Switch to empty list
rbuckton Apr 10, 2024
5716b81
Update text of NOTE
rbuckton Apr 10, 2024
1cef2c8
Add PromiseCapability wrapper around sync dispose in an `await using`
rbuckton Apr 10, 2024
eafa377
Fix missing lookahead restriction
rbuckton Mar 22, 2024
4914a91
Remove superfluous ClassBody restriction
rbuckton Mar 22, 2024
b3d400d
Add entries to esmeta-ignore
rbuckton May 24, 2024
06ac134
Reduce unnecessary Awaits for nullish values in blocks containing `aw…
rbuckton Jun 15, 2024
f64b1c4
Merge pull request #10 from rbuckton/deterministic-collapse-of-await-…
rbuckton Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions esmeta-ignore.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[
"AddDisposableResource",
"AddEntriesFromIterable",
"ArrayAssignmentPattern[0,0].DestructuringAssignmentEvaluation",
"ArrayAssignmentPattern[0,1].DestructuringAssignmentEvaluation",
Expand All @@ -19,18 +20,21 @@
"CreateBuiltinFunction",
"CreateMappedArgumentsObject",
"CreateSharedByteDataBlock",
"DeclarativeEnvironmentRecord.InitializeBinding",
"ForIn/OfBodyEvaluation",
"FunctionBody[0,0].EvaluateFunctionBody",
"GeneratorBody[0,0].EvaluateGeneratorBody",
"GetGlobalObject",
"GetMethod",
"GetPromiseResolve",
"GetThisValue",
"GlobalEnvironmentRecord.InitializeBinding",
"InnerModuleEvaluation",
"LabelledItem[1,0].LabelledEvaluation",
"LengthOfArrayLike",
"MethodDefinition[0,0].DefineMethod",
"ModuleNamespaceCreate",
"ObjectEnvironmentRecord.InitializeBinding",
"OrdinaryFunctionCreate",
"ProxyCreate",
"ScriptEvaluation",
Expand Down