Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Consistently represent expressions that include exponents #3013

Merged
merged 3 commits into from
May 3, 2023

Conversation

gibson042
Copy link
Contributor

This PR addresses two inconsistencies:

  • Some expressions of the form "xy - z" are missing spaces around the operator.
  • Some uses of 𝔽/β„€/ℝ wrap the argument in <emu-eqn> when it includes exponentiation, while others do not. Uses inside of <emu-alg> never include the wrapping, while uses outside of it are evenly split (but never wrap any argument without exponentiation, even if it uses other operations such as division with /):
    $ grep -v '^ *1[.]' spec.html | grep -o '[𝔽℀ℝ][(][^()]*\([(][^()]*[)][^()]*\)*[)]' | grep '<sup>' | sort | uniq -c
          1 𝔽(2<sup>32</sup> - 1)
          1 𝔽(-(2<sup>53</sup> - 1))
          2 𝔽(2<sup>53</sup> - 1)
          1 β„€(-2<sup>63</sup>)
          1 β„€(2<sup>63</sup> - 1)
          1 β„€(2<sup>64</sup> - 1)
          1 𝔽(<emu-eqn>2<sup>15</sup> - 1</emu-eqn>)
          1 𝔽(<emu-eqn>-2<sup>15</sup></emu-eqn>)
          1 𝔽(<emu-eqn>2<sup>16</sup> - 1</emu-eqn>)
          1 𝔽(<emu-eqn>2<sup>31</sup> - 1</emu-eqn>)
          1 𝔽(<emu-eqn>-2<sup>31</sup></emu-eqn>)
          2 𝔽(<emu-eqn>2<sup>32</sup> - 1</emu-eqn>)
    Given the apparent lack of problems from the simpler form and the likelihood of forgetting the more complex form in the absence of lint warnings, I've opted for exclusive use of the former.

@michaelficarra michaelficarra added ready to merge Editors believe this PR needs no further reviews, and is ready to land. establishes editorial conventions labels May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial change establishes editorial conventions ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants