Editorial: In ObjectDefineProperties, use a Record rather than a two-element List #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
approved these changes
May 7, 2023
michaelficarra
approved these changes
May 9, 2023
michaelficarra
added
the
ready to merge
jmdyck
force-pushed
the
ObjectDefineProperties
branch
from
5f68225
to
986235f
Compare
|
(force-pushed to fold in the fixup commit) |
... rather than a two-element List.
ljharb
force-pushed
the
ObjectDefineProperties
branch
from
986235f
to
928a953
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.