Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: add Object.groupBy and Map.groupBy #3176

Merged
merged 1 commit into from Dec 4, 2023
Merged

Normative: add Object.groupBy and Map.groupBy #3176

merged 1 commit into from Dec 4, 2023

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Sep 15, 2023

@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. has test262 tests proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. labels Sep 15, 2023
@ljharb ljharb requested a review from a team September 15, 2023 17:47
@ljharb ljharb mentioned this pull request Sep 15, 2023
Closed
10 tasks
@ljharb ljharb force-pushed the grouping branch 2 times, most recently from 97ca5f2 to a9a7ed3 Compare September 15, 2023 19:00
@ljharb ljharb added the editor call to be discussed in the next editor call label Nov 16, 2023
syg
syg approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just some wordsmithing comments.

spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
jmdyck
jmdyck previously requested changes Nov 17, 2023
View reviewed changes
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
@ljharb ljharb requested a review from jmdyck November 18, 2023 02:17
ljharb added a commit to ljharb/ecma262 that referenced this pull request Nov 21, 2023
@ljharb
Normative: add Object.groupBy and Map.groupBy (tc39#3176)
a759171 
See https://tc39.es/proposal-array-grouping/
@ljharb ljharb dismissed jmdyck’s stale review November 21, 2023 12:28

changes addressed

jmdyck
jmdyck reviewed Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@jmdyck jmdyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

spec.html Show resolved Hide resolved
ljharb added a commit to ljharb/ecma262 that referenced this pull request Nov 23, 2023
@ljharb
Normative: add Object.groupBy and Map.groupBy (tc39#3176)
671eaca 
See https://tc39.es/proposal-array-grouping/
@ljharb ljharb removed the editor call to be discussed in the next editor call label Nov 23, 2023
ljharb added a commit to ljharb/ecma262 that referenced this pull request Nov 23, 2023
@ljharb
Normative: add Object.groupBy and Map.groupBy (tc39#3176)
5afb528 
See https://tc39.es/proposal-array-grouping/
bakkot
bakkot reviewed Nov 23, 2023
View reviewed changes
spec.html Show resolved Hide resolved
@ljharb ljharb added has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. and removed pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Nov 27, 2023
@ljharb
Copy link
Member Author

ljharb commented Nov 27, 2023

This achieved consensus today at TC39.

@ljharb ljharb marked this pull request as ready for review November 27, 2023 19:07
@aliscco aliscco mentioned this pull request Nov 30, 2023
Open
@Pyrolistical Pyrolistical mentioned this pull request Dec 1, 2023
Closed
@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Dec 4, 2023
@ljharb ljharb merged commit 3a9c9dc into tc39:main Dec 4, 2023
10 checks passed
@ljharb ljharb deleted the grouping branch December 4, 2023 16:24
@aliscco aliscco mentioned this pull request Dec 20, 2023
Open
zhangenming pushed a commit to zhangenming/ecma262 that referenced this pull request Dec 22, 2023
@ljharb @zhangenming
Normative: add Object.groupBy and Map.groupBy (tc39#3176)
09afd9a 
See https://tc39.es/proposal-array-grouping/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot approved these changes

@jmdyck jmdyck jmdyck left review comments

@syg syg syg approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

Assignees
No one assigned
Labels
has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ljharb @syg @michaelficarra @bakkot @jmdyck