Layering: the [[Realm]] of a Script Record cannot be *undefined* #3332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
May 21, 2024
syg
approved these changes
May 21, 2024
ljharb
added
the
layering
bakkot
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3326.
As mentioned in that issue, the editors suspect this was a refactoring issue, since it does not appear to ever actually have been possible for this to be
*undefined*, and in any case is not assigned later. The only caller of ParseScript known to us is in HTML, which passes the realm of an environment settings object, which (I believe) cannot be*undefined*, so this restriction on types matches what the consumer actually passed.