Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize TypedArray, ArrayBuffer and DataView constructors #410

Merged
merged 1 commit into from
Jun 2, 2016
Merged

Normalize TypedArray, ArrayBuffer and DataView constructors #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 31 additions & 28 deletions spec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3773,6 +3773,22 @@ <h1>CanonicalNumericIndexString ( _argument_ )</h1>
</emu-alg>
<p>A <em>canonical numeric string</em> is any String value for which the CanonicalNumericIndexString abstract operation does not return *undefined*.</p>
</emu-clause>

<!-- es6num="7.1.17" -->
<emu-clause id="sec-toindex" aoid="ToIndex">
<h1>ToIndex ( _value_ )</h1>
<p>The abstract operation ToIndex returns _value_ argument converted to a numeric value if it is a valid integer index value. This abstract:</p>
<emu-alg>
1. If _value_ is *undefined*, then
1. Let _index_ be *0*.
1. Else,
1. Let _integerIndex_ be ? ToInteger(_value_).
1. If _integerIndex_ < 0, throw a *RangeError* exception.
1. Let _index_ be ! ToLength(_integerIndex_).
1. If SameValueZero(_integerIndex_, _index_) is *false*, throw a *RangeError* exception.
1. Return _index_.
</emu-alg>
</emu-clause>
</emu-clause>

<!-- es6num="7.2" -->
Expand Down Expand Up @@ -31615,10 +31631,7 @@ <h1>_TypedArray_ ( _length_ )</h1>
<emu-alg>
1. Assert: Type(_length_) is not Object.
1. If NewTarget is *undefined*, throw a *TypeError* exception.
1. If _length_ is *undefined*, throw a *TypeError* exception.
1. Let _numberLength_ be ? ToNumber(_length_).
1. Let _elementLength_ be ToLength(_numberLength_).
1. If SameValueZero(_numberLength_, _elementLength_) is *false*, throw a *RangeError* exception.
1. Let _elementLength_ be ? ToIndex(_length_).
1. Let _constructorName_ be the String value of the Constructor Name value specified in <emu-xref href="#table-49"></emu-xref> for this <var>TypedArray</var> constructor.
1. Return ? AllocateTypedArray(_constructorName_, NewTarget, <code>"%<var>TypedArray</var>Prototype%"</code>, _elementLength_).
</emu-alg>
Expand Down Expand Up @@ -31734,26 +31747,24 @@ <h1>_TypedArray_ ( _object_ )</h1>
<emu-clause id="sec-typedarray-buffer-byteoffset-length">
<h1>_TypedArray_ ( _buffer_ [ , _byteOffset_ [ , _length_ ] ] )</h1>
<p>This description applies only if the _TypedArray_ function is called with at least one argument and the Type of the first argument is Object and that object has an [[ArrayBufferData]] internal slot.</p>
<p>_TypedArray_ called with arguments _buffer_, _byteOffset_, and _length_ performs the following steps:</p>
<p>_TypedArray_ called with at least one argument _buffer_ performs the following steps:</p>
<emu-alg>
1. Assert: Type(_buffer_) is Object and _buffer_ has an [[ArrayBufferData]] internal slot.
1. If NewTarget is *undefined*, throw a *TypeError* exception.
1. Let _constructorName_ be the String value of the Constructor Name value specified in <emu-xref href="#table-49"></emu-xref> for this <var>TypedArray</var> constructor.
1. Let _O_ be ? AllocateTypedArray(_constructorName_, NewTarget, <code>"%<var>TypedArray</var>Prototype%"</code>).
1. Let _constructorName_ be the String value of _O_'s [[TypedArrayName]] internal slot.
1. Let _elementSize_ be the Number value of the Element Size value in <emu-xref href="#table-49"></emu-xref> for _constructorName_.
1. Let _offset_ be ? ToInteger(_byteOffset_).
1. If _offset_ &lt; 0, throw a *RangeError* exception.
1. If _offset_ is *-0*, let _offset_ be *+0*.
1. Let _offset_ be ? ToIndex(_byteOffset_).
1. If _offset_ modulo _elementSize_ &ne; 0, throw a *RangeError* exception.
1. If IsDetachedBuffer(_buffer_) is *true*, throw a *TypeError* exception.
1. Let _bufferByteLength_ be the value of _buffer_'s [[ArrayBufferByteLength]] internal slot.
1. If _length_ is *undefined*, then
1. If _length_ is either not present or *undefined*, then
1. If _bufferByteLength_ modulo _elementSize_ &ne; 0, throw a *RangeError* exception.
1. Let _newByteLength_ be _bufferByteLength_ - _offset_.
1. If _newByteLength_ &lt; 0, throw a *RangeError* exception.
1. Else,
1. Let _newLength_ be ? ToLength(_length_).
1. Let _newLength_ be ? ToIndex(_length_).
1. Let _newByteLength_ be _newLength_ &times; _elementSize_.
1. If _offset_+_newByteLength_ &gt; _bufferByteLength_, throw a *RangeError* exception.
1. Set _O_'s [[ViewedArrayBuffer]] internal slot to _buffer_.
Expand Down Expand Up @@ -33004,13 +33015,11 @@ <h1>The ArrayBuffer Constructor</h1>

<!-- es6num="24.1.2.1" -->
<emu-clause id="sec-arraybuffer-length">
<h1>ArrayBuffer ( _length_ )</h1>
<p>ArrayBuffer called with argument _length_ performs the following steps:</p>
<h1>ArrayBuffer ( [ _length_ ] )</h1>
<p>When the `ArrayBuffer` function is called with optional argument _length_, the following steps are taken:</p>
<emu-alg>
1. If NewTarget is *undefined*, throw a *TypeError* exception.
1. Let _numberLength_ be ? ToNumber(_length_).
1. Let _byteLength_ be ToLength(_numberLength_).
1. If SameValueZero(_numberLength_, _byteLength_) is *false*, throw a *RangeError* exception.
1. Let _byteLength_ be ? ToIndex(_length_).
1. Return ? AllocateArrayBuffer(NewTarget, _byteLength_).
</emu-alg>
</emu-clause>
Expand Down Expand Up @@ -33141,9 +33150,7 @@ <h1>GetViewValue ( _view_, _requestIndex_, _isLittleEndian_, _type_ )</h1>
1. If Type(_view_) is not Object, throw a *TypeError* exception.
1. If _view_ does not have a [[DataView]] internal slot, throw a *TypeError* exception.
1. Assert: _view_ has a [[ViewedArrayBuffer]] internal slot.
1. Let _numberIndex_ be ? ToNumber(_requestIndex_).
1. Let _getIndex_ be ToInteger(_numberIndex_).
1. If _numberIndex_ &ne; _getIndex_ or _getIndex_ &lt; 0, throw a *RangeError* exception.
1. Let _getIndex_ be ? ToIndex(_requestIndex_).
1. Let _isLittleEndian_ be ToBoolean(_isLittleEndian_).
1. Let _buffer_ be the value of _view_'s [[ViewedArrayBuffer]] internal slot.
1. If IsDetachedBuffer(_buffer_) is *true*, throw a *TypeError* exception.
Expand All @@ -33164,9 +33171,7 @@ <h1>SetViewValue ( _view_, _requestIndex_, _isLittleEndian_, _type_, _value_ )</
1. If Type(_view_) is not Object, throw a *TypeError* exception.
1. If _view_ does not have a [[DataView]] internal slot, throw a *TypeError* exception.
1. Assert: _view_ has a [[ViewedArrayBuffer]] internal slot.
1. Let _numberIndex_ be ? ToNumber(_requestIndex_).
1. Let _getIndex_ be ToInteger(_numberIndex_).
1. If _numberIndex_ &ne; _getIndex_ or _getIndex_ &lt; 0, throw a *RangeError* exception.
1. Let _getIndex_ be ? ToIndex(_requestIndex_).
1. Let _numberValue_ be ? ToNumber(_value_).
1. Let _isLittleEndian_ be ToBoolean(_isLittleEndian_).
1. Let _buffer_ be the value of _view_'s [[ViewedArrayBuffer]] internal slot.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Missed that one when I fixed the similar issue for the typed array constructors.

Expand All @@ -33189,22 +33194,20 @@ <h1>The DataView Constructor</h1>

<!-- es6num="24.2.2.1" -->
<emu-clause id="sec-dataview-buffer-byteoffset-bytelength">
<h1>DataView (_buffer_, _byteOffset_, _byteLength_ )</h1>
<p>`DataView` called with arguments _buffer_, _byteOffset_, and _byteLength_ performs the following steps:</p>
<h1>DataView ( _buffer_ [ , _byteOffset_ [ , _byteLength_ ] ] )</h1>
<p>When the `DataView` is called with at least one argument _buffer_, the following steps are taken:</p>
<emu-alg>
1. If NewTarget is *undefined*, throw a *TypeError* exception.
1. If Type(_buffer_) is not Object, throw a *TypeError* exception.
1. If _buffer_ does not have an [[ArrayBufferData]] internal slot, throw a *TypeError* exception.
1. Let _numberOffset_ be ? ToNumber(_byteOffset_).
1. Let _offset_ be ToInteger(_numberOffset_).
1. If _numberOffset_ &ne; _offset_ or _offset_ &lt; 0, throw a *RangeError* exception.
1. Let _offset_ be ? ToIndex(_byteOffset_).
1. If IsDetachedBuffer(_buffer_) is *true*, throw a *TypeError* exception.
1. Let _bufferByteLength_ be the value of _buffer_'s [[ArrayBufferByteLength]] internal slot.
1. If _offset_ &gt; _bufferByteLength_, throw a *RangeError* exception.
1. If _byteLength_ is *undefined*, then
1. If _byteLength_ is either not present or *undefined*, then
1. Let _viewByteLength_ be _bufferByteLength_ - _offset_.
1. Else,
1. Let _viewByteLength_ be ? ToLength(_byteLength_).
1. Let _viewByteLength_ be ? ToIndex(_byteLength_).
1. If _offset_+_viewByteLength_ &gt; _bufferByteLength_, throw a *RangeError* exception.
1. Let _O_ be ? OrdinaryCreateFromConstructor(NewTarget, `"%DataViewPrototype%"`, &laquo; [[DataView]], [[ViewedArrayBuffer]], [[ByteLength]], [[ByteOffset]] &raquo;).
1. Set _O_'s [[DataView]] internal slot to *true*.
Expand Down