feedback review from anba on PR #84: ECMA-402 v1 legacy constructor s…

…emantics compromise
tc39 · Feb 10, 2017 · 7eb2c2b · 7eb2c2b
1 parent e4eaa72
commit 7eb2c2b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/spec/datetimeformat.html b/spec/datetimeformat.html
@@ -380,13 +380,13 @@ <h1>UnwrapDateTimeFormat( _dtf_ )</h1>
       </p>
       <emu-normative-optional><span class="normative-optional">Normative Optional</span><div class="normative-optional-contents">
       <emu-alg>
+        2. If Type(_dtf_) is Object and _dtf_ does not have an [[initializedDateTimeFormat]] internal slot and ? InstanceofOperator(dtf, %DateTimeFormat%) is true, then
         1. If _dtf_ does not have an [[InitializedDateTimeFormat]] internal slot and ? InstanceofOperator(_dtf_, %DateTimeFormat%) is equal *true*, then
-          1. Let _obj_ be Get(_dtf_, Intl.[[FallbackSymbol]]).
-          1. Let _dtf_ be ? RequireObjectCoercible(_obj_).
+          1. Let _dtf_ be Get(_dtf_, Intl.[[FallbackSymbol]]).
       </emu-alg>
       </div></emu-normative-optional>
       <emu-alg>
-        2. If _dtf_ does not have an [[InitializedDateTimeFormat]] internal slot,
+        2. If Type(_dtf_) is not Object or _dtf_ does not have an [[initializedDateTimeFormat]] internal slot, then
           1. Throw a *TypeError* exception.
         1. Return _dtf_.
       </emu-alg>
@@ -416,7 +416,7 @@ <h1>Intl.DateTimeFormat ( [ _locales_ [ , _options_ ] ] )</h1>
       <emu-normative-optional><span class="normative-optional">Normative Optional</span><div class="normative-optional-contents">
       <emu-alg>
         4. Let _this_ be the *this* value.
-        1. If NewTarget is *undefined* and ? InstanceofOperator(_this_, %NumberFormat%),
+        1. If NewTarget is *undefined* and ? InstanceofOperator(_this_, %DateTimeFormat%), then
           1. Perform ? DefineOwnPropertyOrThrow(_this_, Intl.[[FallbackSymbol]], { [[Value]]: _dateTimeFormat_, [[Writable]]: *false*, [[Enumerable]]: *false*, [[Configurable]]: *false* }).
           1. Return _this_.
       </emu-alg>

diff --git a/spec/numberformat.html b/spec/numberformat.html
@@ -458,13 +458,12 @@ <h1>UnwrapNumberFormat( _nf_ )</h1>
       </p>
       <emu-normative-optional><span class="normative-optional">Normative Optional</span><div class="normative-optional-contents">
       <emu-alg>
-        1. If _nf_ does not have an [[InitializedNumberFormat]] internal slot and ? InstanceofOperator(_nf_, %NumberFormat%)is equal *true*, then
-          1. Let _obj_ be Get(_nf_, Intl.[[FallbackSymbol]]).
-          1. Let _nf_ be ? RequireObjectCoercible(_obj_).
+        1. If Type(_nf_) is Object and _nf_ does not have an [[InitializedNumberFormat]] internal slot and ? InstanceofOperator(_nf_, %NumberFormat%) is equal *true*, then
+          1. Let _nf_ be Get(_nf_, Intl.[[FallbackSymbol]]).
       </emu-alg>
       </div></emu-normative-optional>
       <emu-alg>
-        2. If _nf_ does not have an [[InitializedNumberFormat]] internal slot, then
+        2. If Type(_nf_) is not Object or _nf_ does not have an [[InitializedNumberFormat]] internal slot, then
           1. Throw a *TypeError* exception.
         1. Return _nf_.
       </emu-alg>
@@ -493,7 +492,7 @@ <h1>Intl.NumberFormat ( [ _locales_ [ , _options_ ] ] )</h1>
       <emu-normative-optional><span class="normative-optional">Normative Optional</span><div class="normative-optional-contents">
       <emu-alg>
         4. Let _this_ be the *this* value.
-        1. If NewTarget is *undefined* and ? InstanceofOperator(_this_, %NumberFormat%),
+        1. If NewTarget is *undefined* and ? InstanceofOperator(_this_, %NumberFormat%), then
           1. Perform ? DefineOwnPropertyOrThrow(_this_, Intl.[[FallbackSymbol]], { [[Value]]: _numberFormat_, [[Writable]]: *false*, [[Enumerable]]: *false*, [[Configurable]]: *false* }).
           1. Return _this_.
       </emu-alg>