-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'length' property of DateTime Format Function #76
Comments
I'm fine with the new semantics v2 semantics remaining in place for v3. V8 has changed the length of a whole bunch of functions for ES2015 compliance, and we haven't gotten a lot of web-compat-based pushback. So I'll be surprised if this ends up being an issue. |
Not concerned with changing length either. |
Thanks you guys. @anba do you want to send the PR? or should I take care of it? we are all running against time! |
@caridy Do we need any PR for ecma402? Unless I'm misunderstanding @littledan's answer, he's okay with the v2 change. |
They are Ok with the change, but the change was not listed in the Annex B, maybe we should just add it there. |
Ah ok, I understand. It's probably better if you prepare a PR, because it's already a bit late in Europe. 😄 |
closes #76: annex B - 'length' property of DateTime Format Function set to 1 in 2nd edition
Analogous to tc39/ecma402#76 This patch does not require a note about the length, as removing the square brackets around the argument implicitly makes the length 1.
The 'length' property of the DateTime Format function returned from get Intl.DateTimeFormat.prototype.format changed from 0 to 1 in ECMA-402, 2nd ed.
In ECMA-402, 1st ed:
In ECMA-402, 2nd ed:
The change is not listed in Annex B, so I'm not sure if it was intentional.
(V8 and SpiderMonkey still return 0, test262 also tests for 0 (https://github.com/tc39/test262/blob/master/test/intl402/DateTimeFormat/prototype/format/12.3.2_1_a_L15.js). Only JavaScriptCore already returns 1.)
The text was updated successfully, but these errors were encountered: