Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Clarify handling of time zone names #624

Merged
merged 9 commits into from
Dec 15, 2021
Merged

Editorial: Clarify handling of time zone names #624

merged 9 commits into from
Dec 15, 2021

Conversation

gibson042
Copy link
Contributor

No description provided.

ptomato
ptomato reviewed Nov 16, 2021
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at Richard's similar changes in Temporal and I think these changes are a good idea. (But I'm not a 402 reviewer)

@gibson042 gibson042 mentioned this pull request Nov 16, 2021
Merged
ryzokuken
ryzokuken approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few questions inline.

spec/locales-currencies-tz.html Outdated Show resolved Hide resolved
spec/locales-currencies-tz.html Show resolved Hide resolved
@gibson042 gibson042 mentioned this pull request Dec 1, 2021
Merged
@ryzokuken
Copy link
Member

Thanks @gibson042! Let's merge this.

@ryzokuken ryzokuken merged commit 896ba11 into tc39:master Dec 15, 2021
gibson042 added a commit to gibson042/ecma402 that referenced this pull request Dec 16, 2021
@gibson042
Editorial: Add and use definitions for ASCII-specific operations
b6c85f9 
Ref tc39#624
@gibson042 gibson042 mentioned this pull request Dec 16, 2021
Closed
gibson042 added a commit to gibson042/ecma402 that referenced this pull request Mar 17, 2022
@gibson042
Editorial: Add and use definitions for ASCII-specific operations
b3f471f 
Ref tc39#624
leobalter pushed a commit that referenced this pull request Mar 28, 2022
@gibson042 @leobalter
Editorial: Add and use definitions for ASCII-specific operations
99c1938 
Ref #624
leobalter pushed a commit that referenced this pull request Mar 28, 2022
@gibson042 @leobalter
Editorial: Add and use definitions for ASCII-specific operations
235b3c4 
Ref #624
leobalter pushed a commit that referenced this pull request Mar 28, 2022
@gibson042 @leobalter
Editorial: Add and use definitions for ASCII-specific operations
17141da 
Ref #624
leobalter pushed a commit that referenced this pull request Mar 28, 2022
@gibson042 @leobalter
Editorial: Add and use definitions for ASCII-specific operations
cdcac53 
Ref #624
leobalter pushed a commit that referenced this pull request Mar 28, 2022
@gibson042 @leobalter
Editorial: Add and use definitions for ASCII-specific operations
ba8ac6a 
Ref #624
leobalter pushed a commit that referenced this pull request Mar 28, 2022
@gibson042 @leobalter
Editorial: Add and use definitions for ASCII-specific operations
129c790 
Ref #624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato left review comments

@ryzokuken ryzokuken ryzokuken approved these changes

@justingrant justingrant Awaiting requested review from justingrant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gibson042 @ryzokuken @ptomato