Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Replace AvailableCanonicalCalendars with AvailableCalendars #889

Merged
merged 1 commit into from
Jun 4, 2024

Commits on Jun 4, 2024

  1. Editorial: Replace AvailableCanonicalCalendars with AvailableCalendars

    AvailableCalendars should return all possible aliases, so that other
    places in the spec (e.g. in the future, validating a string calendar ID in
    Temporal) can use them to determine whether a given input value is valid.
    This input value can subsequently be canonicalized by another abstract
    operation, CanonicalizeUValue, which we can use in several other places.
    
    In Intl.supportedValuesOf(), on the other hand, we should not return all
    possible aliases, so we filter them out using CanonicalizeUValue before
    returning the list of AvailableCalendars codes as an array to the caller.
    
    See tc39/proposal-intl-enumeration#49. This is the
    part of that PR that I consider relevant for the future integration of
    Temporal. The time zone parts were already done as part of tc39#876. If
    desired, I could implement the rest of that PR, additionally supporting
    collation, currency, numbering system, and unit canonicalization.
    
    Closes: tc39#726
    ptomato authored and gibson042 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    f14cbed View commit details
    Browse the repository at this point in the history