Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parabreak processing breaks spec rendering #71

Closed
gibson042 opened this issue Jun 3, 2020 · 4 comments · Fixed by #72
Closed

parabreak processing breaks spec rendering #71

gibson042 opened this issue Jun 3, 2020 · 4 comments · Fixed by #72

Comments

@gibson042
Copy link
Contributor

Something changed since v3.19.1 broke rendering of ECMA 402: tc39/ecma402#450

New versions stop parsing after encountering double newlines as encountered at https://github.com/tc39/ecma402/blob/334b79ecacbb5283c27c968abf17e9235187acad/spec/overview.html#L31-L32 .
@gibson042
Copy link
Contributor Author

The "Error: expecting EOF, got parabreak" message also leaves much to be desired, it took a fair amount of digging to pinpoint the problem.

@bakkot
Copy link
Contributor

bakkot commented Jun 3, 2020

Hm, sorry about that. I'll take a look.

@gibson042
Copy link
Contributor Author

Hang on for a few minutes; I think I've got a fix.

gibson042 added a commit to gibson042/ecmarkdown that referenced this issue Jun 3, 2020
@gibson042
Tokenize 2 *or more* line feeds as a single parabreak
6cabbb2 
Fixes tc39#71
@gibson042 gibson042 mentioned this issue Jun 3, 2020
Merged
@bakkot bakkot closed this as completed in #72 Jun 3, 2020
@bakkot
Copy link
Contributor

bakkot commented Jun 3, 2020

ecmarkdown 5.0.2 is published, and ecmarkup 3.23.0 is published including it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tokenize 2 *or more* line feeds as a single parabreak gibson042/ecmarkdown
2 participants
@gibson042 @bakkot