Consistently trim comma-separated list items

tc39 · Jan 18, 2023 · bcbfd63 · bcbfd63
1 parent 89b19a7
commit bcbfd63
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/src/Meta.ts b/src/Meta.ts
@@ -17,7 +17,7 @@ export default class Meta extends Builder {
         node
           .getAttribute('effects')!
           .split(',')
-          .map(c => c.trim()),
+          .map(e => e.trim()),
         node
       );
       for (const effect of effects) {
@@ -40,6 +40,7 @@ export default class Meta extends Builder {
       const classNames = node
         .getAttribute('effects')!
         .split(',')
+        .map(e => e.trim())
         .map(e => `e-${e}`)
         .join(' ');
       const span = spec.doc.createElement('span');

diff --git a/src/Spec.ts b/src/Spec.ts
@@ -2005,7 +2005,7 @@ async function walk(walker: TreeWalker, context: Context) {
       throw new Error('oldids found on unsupported element: ' + context.node.nodeName);
     }
     oldids
-      .split(/,/g)
+      .split(',')
       .map(s => s.trim())
       .forEach(oid => {
         const s = spec.doc.createElement('span');

diff --git a/src/Xref.ts b/src/Xref.ts
@@ -46,13 +46,19 @@ export default class Xref extends Builder {
       node.parentElement.children[0] === node
     ) {
       if (node.parentElement.hasAttribute('effects')) {
-        const addEffects = node.parentElement.getAttribute('effects')!.split(',');
+        const addEffects = node.parentElement
+          .getAttribute('effects')!
+          .split(',')
+          .map(e => e.trim());
         if (addEffects.length !== 0) {
           this.addEffects = validateEffects(spec, addEffects, node.parentElement);
         }
       }
       if (node.parentElement.hasAttribute('suppress-effects')) {
-        const suppressEffects = node.parentElement.getAttribute('suppress-effects')!.split(',');
+        const suppressEffects = node.parentElement
+          .getAttribute('suppress-effects')!
+          .split(',')
+          .map(e => e.trim());
         if (suppressEffects.length !== 0) {
           this.suppressEffects = validateEffects(spec, suppressEffects, node.parentElement);
         }