Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting nits #30

Closed
3 tasks done
bterlson opened this issue Aug 6, 2015 · 9 comments
Closed
3 tasks done

Formatting nits #30

bterlson opened this issue Aug 6, 2015 · 9 comments
Labels
Milestone

Comments

@bterlson
Copy link
Member

bterlson commented Aug 6, 2015

As reported by Domenic in tc39/proposal-async-await#59:

  • Add styling for emu-const
  • Remove emu-t right margin when inside normal text.
  • Make Completion auto-link appropriately.
@ljharb
Copy link
Member

ljharb commented Aug 8, 2015

It seems like v1.7.0 also no longer includes newlines in the generated HTML between steps in emu-alg blocks - is this related, or should it be a separate issue? (see tc39/proposal-string-pad-start-end@5b008b8#diff-3540caefa502006d8a33cb1385720803R13)

@bterlson
Copy link
Member Author

bterlson commented Aug 8, 2015

@ljharb That was as a result of removing the beautify step from EMD so if the line breaks important to you, file a bug there!

@ljharb
Copy link
Member

ljharb commented Aug 8, 2015

It looks like the issue was decided in tc39/ecmarkdown#12 - I'm not sure why this particular formatting would be that slow.

@domenic
Copy link
Member

domenic commented Aug 8, 2015

If you want to beautify, beautify the whole document as a post-processing step. Don't build that into the tools.

@ljharb
Copy link
Member

ljharb commented Aug 8, 2015

Do you have a recommended tool to use? Typically I've found it easiest to beautify during generation of HTML, but super difficult to do reliably after.

@domenic
Copy link
Member

domenic commented Aug 8, 2015

Well, we were already doing it after the generation of the HTML, so you're not going to get anything different. js-beautify is what I used.

@ljharb
Copy link
Member

ljharb commented Aug 8, 2015

Sounds good, I'll try that, thanks.

Update: done in tc39/proposal-string-pad-start-end@c0decde - thanks for the tip

@bterlson bterlson modified the milestone: Version 2.0 Aug 12, 2015
@bterlson
Copy link
Member Author

Not special-casing Completion - Completion{ ... } will link to the term Completion, which seems fine. Just need Completion to have a dfn in the source doc so it ends up in the biblio. See jmdyck/es-spec-emu#6.

@bterlson
Copy link
Member Author

These are all addressed in 2.0.0-beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants