Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Editorial and styling nits #59

Closed
5 of 8 tasks
domenic opened this issue Aug 3, 2015 · 6 comments
Closed
5 of 8 tasks

Editorial and styling nits #59

domenic opened this issue Aug 3, 2015 · 6 comments

Comments

@domenic
Copy link
Member

domenic commented Aug 3, 2015

@anba
Copy link
Contributor

anba commented Aug 4, 2015

Completion(result) is not auto-linking (maybe you meant NormalCompletion?)

Completion(result) is correct, it is used to highlight that the original completion value result is returned as is.

@bterlson
Copy link
Member

bterlson commented Aug 6, 2015

https://tc39.github.io/ecmascript-asyncawait/spec-toc.html#abstract-ops-async-function-await step 3 is all messed up.

This was due to the emd greedy comment bug (not present in the actual spec).

Constructor arguments should not be italicized https://tc39.github.io/ecmascript-asyncawait/spec-toc.html#async-function-constructor-arguments

I like italicizing all parameters regardless of context (using either _ or | depending on the type of parameter). I'll be using that convention going forward I think :)

@bterlson
Copy link
Member

bterlson commented Aug 6, 2015

Created tc39/ecmarkup#30 to fix the emu issues you highlighted.

@domenic
Copy link
Member Author

domenic commented Aug 8, 2015

Since the EMD changes, strings are no longer auto-coded; need to add that back in a few places

Still spotting some of these, e.g. https://tc39.github.io/ecmascript-asyncawait/#async-function-constructor-arguments and following sections.

@domenic
Copy link
Member Author

domenic commented Aug 8, 2015

@bterlson
Copy link
Member

All of these are fixed with the latest Emu + previous manual fixes. Please open new bugs for any remaining issues!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants