This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Implement new min/max semantics #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the proposal in tc39#67 These min and max functions follow the Math.min and Math.max semantics, and are arguably the more intuitive and semantics. This patch also introduces minNum and maxNum functions, which follow the IEEE-754 minNum and maxNum semantics.
|
LGTM. Thanks for the PR. Just one nit, would you like to add test cases for |
|
Thanks for spotting that. I added tests now, which turned up a copy+pasto bug in SIMD.float64x2.minNum! |
johnmccutchan
added a commit
that referenced
this pull request
Oct 27, 2014
Implement new min/max semantics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the proposal in
#67
These min and max functions follow the Math.min and Math.max semantics,
and are arguably the more intuitive and semantics.
This patch also introduces minNum and maxNum functions, which follow the
IEEE-754 minNum and maxNum semantics.