This repository has been archived by the owner on Jun 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Polyfill: two conformance fixes #27
Open
rwaldron
wants to merge
2
commits into
tc39:master
Choose a base branch
from
rwaldron:ValidateAtomicAccess
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaldron
commented
Mar 19, 2020
let timeout = timeout_ === undefined ? Infinity : +timeout_; | ||
|
||
// Range checking for the index. | ||
|
||
ia[index]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is replaced by ValidateAtomicAccess(...)
ExE-Boss
reviewed
Dec 2, 2020
if (typeof ia != "object" || !(ia instanceof Int32Array) || !(ia.buffer instanceof SharedArrayBuffer)) | ||
throw new TypeError("Expected shared memory"); | ||
if (typeof ia != "object" || | ||
(!(ia instanceof Int32Array) && !(ia instanceof BigInt64Array)) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ia instanceof TypedArray
line should use:
TypedArrayProto_getToStringTag(ia) !== undefined
Which is defined using:
var TypedArrayProto_getToStringTag = Function.prototype.call.bind(
Object.getOwnPropertyDescriptor(
Object.getPrototypeOf(Uint8Array.prototype),
Symbol.toStringTag,
).get,
);
Refs: https://tc39.es/ecma262/#sec-get-%typedarray%.prototype-@@tostringtag
throw new TypeError("Expected shared memory"); | ||
if (typeof ia != "object" || | ||
(!(ia instanceof Int32Array) && !(ia instanceof BigInt64Array)) || | ||
!(ia.buffer instanceof SharedArrayBuffer)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the ia.buffer instanceof SharedArrayBuffer
line should instead use:
IsSharedArrayBuffer(ia.buffer)
Which is defined using:
var SharedArrayBufferProto_getByteLength = Function.prototype.call.bind(
Object.getOwnPropertyDescriptor(
SharedArrayBuffer.prototype,
"byteLength",
).get,
);
function IsSharedArrayBuffer(obj) {
try {
SharedArrayBufferProto_getByteLength(obj);
return true;
} catch (e) {
return false;
}
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates two fixes into one PR, but keeps them separate by commit