Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
0 parents
commit 816c710
Showing
6 changed files
with
2,824 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
package-lock=false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
MIT License | ||
|
||
Copyright (c) 2017 ECMA TC39 and contributors | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
in the Software without restriction, including without limitation the rights | ||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
copies of the Software, and to permit persons to whom the Software is | ||
furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all | ||
copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
SOFTWARE. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,123 @@ | ||
# Collection {toKey, toValue} | ||
|
||
This proposal seeks to add a `toKey` and `toValue` parameter to collection creation. | ||
|
||
[Rendered Spec](https://tc39.github.io/proposal-richer-keys/collection-rekey/index.html) | ||
|
||
## Use cases | ||
|
||
### Specialized maps | ||
|
||
Given an application with User Objects it may be desirable to create collections based upon username and email for separate purposes. | ||
|
||
```mjs | ||
new Map(undefined, { | ||
toKey({email}) { | ||
return email; | ||
}, | ||
toValue(state) { | ||
return state instanceof AccountState ? | ||
state : | ||
new AccountState(state); | ||
} | ||
}); | ||
``` | ||
|
||
```mjs | ||
new Set(undefined, { | ||
toValue({username}) { | ||
return username; | ||
} | ||
}); | ||
``` | ||
|
||
### Checked keys | ||
|
||
It is a common occurance to want to check types when performaning operations on collections. This can be done during keying. | ||
|
||
```mjs | ||
new Map(undefined, { | ||
toKey(user) { | ||
if (user instanceof User !== true) { | ||
throw new TypeError('Expected User for key'); | ||
} | ||
return user; | ||
} | ||
}); | ||
``` | ||
|
||
## FAQ | ||
|
||
### How do other languages handle this customized keying? | ||
|
||
A collection of references can be found via [this document](https://docs.google.com/document/d/1qxSLyiButKocM6ENufhvnNJcZh18nDAWcFT2HlTJahQ/edit#). | ||
|
||
Generally it falls into using container types. If you wanted to create a `Map` of `People` by `person.email`. You would implement a wrapper class `PersonByEmail` to use as your key, and others for keying of other aspects. Static typing and compiler/language enforced coercion can alleviate problems with misusing collections, but wrapping and unwrapping is manual in scenarios with dynamic typing that cannot be coerced automatically. | ||
|
||
This proposal would provide a hook to do that manual wrapping and unwrapping without requiring the user of a collection to remain vigilant about properly marshalling keys before providing them to the collection. | ||
|
||
### When are the normalization steps applied? | ||
|
||
Normalization is applied when data is incoming to find the identity of the key location in `[[MapData]]` and when placing the value in `[[SetData]]` or `[[MapData]]`. e.g. | ||
|
||
```mjs | ||
const map = new Map([], { | ||
toKey: String | ||
}); | ||
// stored using { [[Key]]: "1", [[Value]]: "one" } in map.[[MapData]] | ||
map.set(1, 'one'); | ||
// looks for corresponding { [[Key]]: "1" } in map.[[MapData]] | ||
map.has(1); // true | ||
// functions directly exposing the underlying entry list are unaffected | ||
[...map.entries()]; // [["1", "one"]] | ||
|
||
const set = new Set([], {toValue: JSON.stringify}); | ||
// stored using { [[Value]]: '{"path": "/foo"}' } in set.[[SetData]] | ||
set.add({path: '/foo'}); | ||
// looks for corresponding { [[Value]]: '{"path": "/foo"}' } in set.[[SetData]] | ||
set.has({path: '/foo')}; | ||
// functions directly exposing the underlying entry list are unaffected | ||
[...set]; // ['{"path": "/foo"}'] | ||
``` | ||
Normalization is not done when iterating or returning internal data, it is only done on parameters. | ||
### Why are Sets only given `toValue`? | ||
Sets are collections of values, and do not have a mapping operation from one value to another. | ||
### Why not `value[Symbol.toKey]`? | ||
Having specialized identity conflicts with the idea of having multiple kinds of specialized maps per type of value. It also would cause conflicts when wanting to specialize keys that are based upon primitives. | ||
### Why not encourage extending collections? | ||
1. This would be succeptible to prototype crawling such as: | ||
```mjs | ||
myCustomMap.__proto__.get.call(myCustomMap, key); | ||
``` | ||
which would somewhat invalidate the idea of checking types of keys. | ||
2. It prevents needing to synchronize all of the methods which is a fair amount of boiler plate and potential place for code going out of sync. It also means that your custom implementation will work even if new methods are added to collections in the JS standard library: | ||
```mjs | ||
class MyMap extends Map { | ||
constructor([...entries]) { | ||
super(entries.map(...)); | ||
} | ||
delete(k) { ... } | ||
get(k) { ... } | ||
has(k) { ... } | ||
set(k, v) { ... } | ||
} | ||
``` | ||
If we add something like `emplace()` this code now needs to be updated or it will have bugs if people expect it to work like a standard Map. | ||
This is roughly [the fragile base class problem](https://en.wikipedia.org/wiki/Fragile_base_class), where `Map` is the base class. | ||
3. Even if this is a userland solution, it seems prudent to allow easier usage of maps. We should aim to alleviate developers without requiring that all new features have new kernel semantics. I spoke of this with respect to [expanding the standard library](https://docs.google.com/presentation/d/1QSwQYJz4c1VESEKTWPqrAPbDn_y9lTBBjaWRjej1c-w/view#slide=id.p). | ||
4. Composition, while extending is nice it doesn't always allow for simple chaining and composition of features. If we introduce `RekeyableMap` as a concrete base class it may conflict with other base classes that may be introduced like if there was `InsertIfMissingMap`. Since both are base classes it would not allow both features to be combined easily. |
Oops, something went wrong.