Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about TypeScript's implementation #257

Closed
wants to merge 1 commit into from
Closed

Add note about TypeScript's implementation #257

wants to merge 1 commit into from

Conversation

jaller94
Copy link

An experimental implementation was added to TypeScript in microsoft/TypeScript@62ba369.
One must enable the compiler flag experimentalDecorators to use it.

@trotyl
Copy link
Contributor

trotyl commented Mar 10, 2019

What implemented in TypeScript is not the decorator proposal in this repo, but a different proposal known as stage-0/stage-1 decorator.

@jaller94
Copy link
Author

Feel free to close this then.
My goal was to raise the working group's awareness of this implementation, as the TypeScript documentation links to this repo and mentions the stage-2 proposal.
https://www.typescriptlang.org/docs/handbook/decorators.html

@trotyl
Copy link
Contributor

trotyl commented Mar 11, 2019

See compat-table/compat-table#1047 for more information, mentioning of decorator implementation in TypeScript is wrong should be completely removed.

@littledan
Copy link
Member

I think it's useful to have this context and explain how it's a different proposal. Let's write that up on top of #250 , which I expect to land soon.

@littledan
Copy link
Member

Closing this PR, as the current explainer documents the relationship between TypeScript decorators and these.

@littledan littledan closed this Mar 25, 2019
@jaller94 jaller94 deleted the jaller94-typescript branch January 6, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants