Revert changes to ForBodyEvaluation/CreatePerIterationEnvironment #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A preview of this PR can be found at https://tc39.es/proposal-explicit-resource-management/pr/140. |
rbuckton
changed the title
rbuckton
changed the title
|
@tc39/ecma262-editors can you review this change? |
rbuckton
force-pushed
the
cleanup-for-evaluation
branch
from
3a6915f
to
9a8800d
Compare
bakkot
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreatePerIterationEnvironment only ever creates
normalbindings, so there is nothing to actually dispose in ForBodyEvaluation. The only place we actually need to handle specifically in aforstatement is in ForLoopEvaluation, since anyusingdeclaration in the ForDeclaration nonterminal would be defined in the non-per-iteration environment (loopEnv).