Allow condition keys to be StringLiterals in addition to IdentifierNames #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandclark
force-pushed
the
dandclark/let-condition-entries-be-strings
branch
from
9714a7c
to
c38a335
Compare
littledan
approved these changes
Jul 17, 2020
|
Just use |
|
|
I am advocating for it. I would expect any LiteralPropertyName to be allowed in that position. |
|
Oh, I misunderstood. Let's discuss in #78. |
xtuc
force-pushed
the
dandclark/let-condition-entries-be-strings
branch
from
c38a335
to
cff6dd5
Compare
|
As discussed during the July 2020 TC39 meeting, it seems that people are in favor of allowing quotes, merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Condition keys are currently limited to being IdentifierNames. This change additionally allows them to be string literals (' or ") , so that the condition entries list can be written a bit more like an object literal.
Numeric literals are still not permitted.
It's not yet certain that we want to go this route, so this won't be merged until we reach some conclusion regarding the discussion in #78.
Closes #78.